Add extra styles for focused/hovered active outline buttons #19201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| &.focus { | ||
| color: #fff; | ||
| background-color: darken($color, 17%); | ||
| border-color: darken($color, 25%); |
There was a problem hiding this comment.
Line should be indented 6 spaces, but was indented 10 spaces
|
before (left) and after (right) comparison (using a modified bit in our docs) - note before that an active outline button style was the same when hovered with mouse or focused with keyboard (minus the very faint outline in the latter case). this patch should make it a lot clearer. |
patrickhlauke
added a commit
that referenced
this pull request
Feb 15, 2016
…-fix Add extra styles for focused/hovered active outline buttons
|
@cvrebert any idea why @houndci-bot flagged those spaces, when just a few lines previously (especially in the current mixin for |
|
@patrickhlauke Not really, although we don't align |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ports the same approach from 1f153b6#diff-edb9cd89b66120ef946a81de31f6bb06 (originally #16154 in v3) to outline buttons as well
Fixes #19199