Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V4 list-group with an active li, invisible link #21755

Closed
Johann-S opened this issue Jan 17, 2017 · 5 comments
Closed

V4 list-group with an active li, invisible link #21755

Johann-S opened this issue Jan 17, 2017 · 5 comments
Labels

Comments

@Johann-S
Copy link
Member

It seems when an li in .list-group with .active, links aren't visible

See : https://jsfiddle.net/m6zz8sw4/1/

@Quy
Copy link
Contributor

Quy commented Jan 23, 2017

Why not do it as instructed in the doc?

Use <a>s or <button>s to create actionable list group items with hover, disabled, and active states by adding .list-group-item-action. We separate these pseudo-classes to ensure list groups made of non-interactive elements (like <li>s or <div>s) don’t provide a click or tap affordance.

<div class="list-group">
  <a href="#" class="list-group-item active">
    Cras justo odio
  </a>
  <a href="#" class="list-group-item list-group-item-action">Dapibus ac facilisis in</a>
  <a href="#" class="list-group-item list-group-item-action">Morbi leo risus</a>
  <a href="#" class="list-group-item list-group-item-action">Porta ac consectetur ac</a>
  <a href="#" class="list-group-item list-group-item-action disabled">Vestibulum at eros</a>
</div>

@pvdlg
Copy link
Contributor

pvdlg commented Jan 23, 2017

@Johann-S
Copy link
Member Author

Yes it works well with your example @Quy , but according to the documentation we can use both <ul> and <div>. So for me the behavior should be the same. Am I Wrong ?

@Quy
Copy link
Contributor

Quy commented Jan 23, 2017

I would think so too, however, going by the examples in the documentation, use <ul> for non-interactive elements and <div> with a or button for interactive elements.

@mdo
Copy link
Member

mdo commented Mar 18, 2017

I think I'll close this as a won't fix for now given we try to keep those list groups as singular large click areas. If you need the inner hyperlink, .text-white is also available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants