Allow to use Tab.js with list-group #21756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hell yeah, thanks! |
|
You're welcome 😀👌 |
|
Is there really a point in supporting As far as I can tell both achieve the same thing. The original issue #20620 mention "an example from v3". I think it's intended in v4 to offer vertical nav for this case while in v3 list-group were the way to go. |
This was referenced Jan 22, 2017
Tabs/Scrollspy/.nav/.list-group/.active independent of markup (<nav>, .nav-item, <li> etc...)
#21807
Merged
|
Due to this comment : #21755 (comment) Allow to use this structur of <div class="list-group">
<a href="#home" class="list-group-item active" data-toggle="tab">Home</a>
<a href="#profil" class="list-group-item list-group-item-action" data-toggle="tab">Profil</a>
</div> |
This was referenced Mar 18, 2017
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow Tab.js selector to accept
list-groupRef : #20620