Missing semicolon at the end of bootstrap.js causes issues when bundled with other scripts

[judowalker]

I am bundling bootstrap.js with other scripts and I get a runtime error which I found out is due to a missing semicolon at the end of bootstrap.js:
ba312c2#diff-5492e5c74c97b8b5256879d136b55c88R3631

Only the unminified file is missing the semicolon.

[XhmikosR]

/CC @bardiharborow @Johann-S

That is why I don't like the no semi approach, personally. That being said, can't we just add the end of file semi here?

[Johann-S]

Yes that's just a mistake from stamp.js (Babel add semicolons to our dist files see : https://github.com/twbs/bootstrap/blob/v4-dev/dist/js/bootstrap.js#L97) and when #22888 will be merge stamp.js won't exist 😄

[XhmikosR]

I believe that until that is merged we should fix it in dev branch. Because as you know that might a while to merge... On Jul 31, 2017 11:03, "Johann-S" <notifications@github.com> wrote: Yes that's just a mistake from stamp.js (Babel add semicolons to our dist files see : https://github.com/twbs/bootstrap/blob/v4-dev/dist/js/ bootstrap.js#L97) and when #22888 <#22888> will be merge stamp.js won't exist 😄 — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#23175 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAVVtUbXSsgPi_ltqTJXxmrr-1KuWJjrks5sTYpYgaJpZM4Ond54> .

[XhmikosR]

I'm going to submit a PR later unless you beat me to it. On Jul 31, 2017 11:26, "XhmikosR" <xhmikosr@gmail.com> wrote: I believe that until that is merged we should fix it in dev branch. Because as you know that might a while to merge... On Jul 31, 2017 11:03, "Johann-S" <notifications@github.com> wrote: Yes that's just a mistake from stamp.js (Babel add semicolons to our dist files see : https://github.com/twbs/bootstrap/blob/v4-dev/dist/js/bootst rap.js#L97) and when #22888 <#22888> will be merge stamp.js won't exist 😄 — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#23175 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAVVtUbXSsgPi_ltqTJXxmrr-1KuWJjrks5sTYpYgaJpZM4Ond54> .