-
-
Notifications
You must be signed in to change notification settings - Fork 78.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create component shadow variables to keep consistency across components #23775
Labels
Comments
I'm down! |
Revisiting this, I've put some existing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We are defining different shadows in different components. There are about 25 shadow definitions on variables.
To keep consistency, I think we unify all of them in 4 shadow variables (sm, md, lg and inset) and then reuse them across components.
For example, instead of:
We would have something like:
This follows the same idea as #23674
Before I send a PR I'd like to know what do you guys think?
The text was updated successfully, but these errors were encountered: