Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected Results Using $enable-shadows #23837

Closed
LarryAzevedo opened this issue Sep 5, 2017 · 2 comments
Closed

Unexpected Results Using $enable-shadows #23837

LarryAzevedo opened this issue Sep 5, 2017 · 2 comments

Comments

@LarryAzevedo
Copy link

Changing $enable-shadows to true does not give the results I believe most people are expecting.

Example 1:
screen-shot-2017-09-04-at-3 12 57-pm

Example 2:
input_02

So please consider changing line 339 of variables.scss from $btn-box-shadow: inset 0 1px 0 rgba($white,.15), 0 1px 1px rgba($black,.075) to something like $btn-box-shadow: 0 2px 2px rgba($black,.2).

Also, what do you guys think about having shadows on active nav pills when $enable-shadows is set to true?

@andresgalante
Copy link
Collaborator

Hi @LarryAzevedo although I don't think pills should have shadows I think that shadows in general are all over the place. To me it doesn't matter if the shadow on btns is subtle, since that's an opinion, as long as it's consistent with other elements.

I've described a possible solution here #23775

@LarryAzevedo
Copy link
Author

Hey @andresgalante, thanks for your feedback on pill shadows. As far as your comment:

To me it doesn't matter if the shadow on btns is subtle

I understand that to you it doesn't matter. Heck, it doesn't even matter to me (now that I know it works). But what about others like myself that didn't notice anything different after turning on shadows? Not the greatest user experience.

By the way, I like your solution on #23775

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants