-
-
Notifications
You must be signed in to change notification settings - Fork 78.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unexpected Results Using $enable-shadows #23837
Comments
Hi @LarryAzevedo although I don't think pills should have shadows I think that shadows in general are all over the place. To me it doesn't matter if the shadow on btns is subtle, since that's an opinion, as long as it's consistent with other elements. I've described a possible solution here #23775 |
Hey @andresgalante, thanks for your feedback on pill shadows. As far as your comment:
I understand that to you it doesn't matter. Heck, it doesn't even matter to me (now that I know it works). But what about others like myself that didn't notice anything different after turning on shadows? Not the greatest user experience. By the way, I like your solution on #23775 |
Changing
$enable-shadows
totrue
does not give the results I believe most people are expecting.Example 1:
Example 2:
So please consider changing line 339 of variables.scss from
$btn-box-shadow: inset 0 1px 0 rgba($white,.15), 0 1px 1px rgba($black,.075)
to something like$btn-box-shadow: 0 2px 2px rgba($black,.2)
.Also, what do you guys think about having shadows on active nav pills when
$enable-shadows
is set totrue
?The text was updated successfully, but these errors were encountered: