-
-
Notifications
You must be signed in to change notification settings - Fork 78.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
<picture> with img-thumbnail class #24176
Comments
I've just tested it. @t5k6 you are right, the way we setup images and figures don't support This is fixed by I'll follow the same approach and send a PR. |
|
@XhmikosR Yeap. Sorry, I meant If it goes to reboot we don't document it. if it goes to images.scss then we would have to add a new section to the docs with |
Here is a live example of what this issue is describing with the inline-block solution: |
It's @mdo's final choice. Personally I wouldn't add it to reboot. |
Rather than add a generic |
@t5k6 After testing it again I realized I was wrong, you don't need to change the display of the Use <picture>
<source srcset="/path/to/image.webp" type="image/webp">
<img class="img-thumbnail img-fluid" src="/path/to/image.jpg" alt="">
</picture> The picture will handle where the source of that image comes from. See an example here: https://codepen.io/andresgalante/pen/EwXJdj @mdo There is nothing wrong with the way we handle images. Do you you I think it has value to document this on our docs under images? |
Yeah, good idea—I think it'd be helpful to have a code example and snippet in the Image docs page. |
I am trying to implement
<picture>
tag to selectively serve pictures; webp format for Chrome based browsers and jpeg fallback for other browsers. However using Bootstrap'simg-thumbnail
class is not working properly, it creates handlebar like artifact on border sides.Sample code:
Bootstrap version: 4 beta
The text was updated successfully, but these errors were encountered: