-
-
Notifications
You must be signed in to change notification settings - Fork 78.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inconsistent component default/spacer padding #25057
Comments
i think card-body should be around the table, then at least the border of the table lines up |
Anyone reconsidered #3737 for V4 (or better yet a 3x patch)? |
Closed
We'll probably be syncing the paddings in |
mdo
added a commit
that referenced
this issue
Apr 11, 2020
- Updates horizontal padding across alerts, cards, dropdowns, list groups, and modals to be our default of 1rem - Reassigns some variables to improve ease of customization - Restyles the breadcrumb a smidge to make the background lighter for improved contrast and a little less vertical padding Fixes #25057 for v5.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We've been running into consistency issues using Bootstrap 4beta2's default spacing.
Most of the components (
$table-cell-padding
,$card-spacer-y
,$alert-padding-y
, etc.) use apadding: .75rem
. However, the$spacers
don't include that value. It's not possible to use a built in padding class to match the components, which is very weird.For example, putting a
table
into acard
:Results in HTML that looks like this:
The
.card-header
class is using a hard-coded1.25rem
padding (from$card-spacer-x
), while the table cell is using hard-coded.75rem
(from$table-cell-padding
).I would expect to be able to have some kind of
pl-?
(left) orpt-?
(top) class that matches these components default, since it's in so many places. However, there aren't any Bootstrap-defined classes that you can use to get that.card-header
padding to match all of the default component paddings. I realize we can make our own class, but it seems like an oversight and an actual issue to note.The text was updated successfully, but these errors were encountered: