Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Docs] Role "button" in Navbar dropdowns #26830

Closed
AlessandroVecchi opened this issue Jul 9, 2018 · 4 comments
Closed

[Docs] Role "button" in Navbar dropdowns #26830

AlessandroVecchi opened this issue Jul 9, 2018 · 4 comments
Labels
confirmed docs v4

Comments

@AlessandroVecchi
Copy link

hi,
in the first example
https://getbootstrap.com/docs/4.1/components/navbar/#supported-content
.dropdown-toggle has a "role="button"
in the second example
https://getbootstrap.com/docs/4.1/components/navbar/#nav
"role=button" is missing

which is the correct version?
@XhmikosR
Copy link
Member

XhmikosR commented Jul 9, 2018

/CC @patrickhlauke

@patrickhlauke
Copy link
Member

the one with the role="button". seems to have been missed out in the second one...sigh

@XhmikosR XhmikosR mentioned this issue Jul 9, 2018
Merged
patrickhlauke added a commit that referenced this issue Jul 9, 2018
@patrickhlauke
Docs: add missing role="button" in navbar dropdown example
980f580 
Closes #26830
@patrickhlauke patrickhlauke mentioned this issue Jul 9, 2018
Closed
@patrickhlauke
Copy link
Member

@XhmikosR hah...you beat me to the PR :)

@XhmikosR
Copy link
Member

XhmikosR commented Jul 9, 2018

Yeah, please review that instead :)

patrickhlauke pushed a commit that referenced this issue Jul 9, 2018
@XhmikosR @patrickhlauke
Add missing role="button" in .navbar's .dropdown-toggle
8b50a72 
Fixes #26830
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
confirmed docs v4
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@XhmikosR @patrickhlauke @AlessandroVecchi