Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow our constructors to accept a CSS selector #29417

Closed
Johann-S opened this issue Sep 17, 2019 · 1 comment · Fixed by #32245
Closed

Allow our constructors to accept a CSS selector #29417

Johann-S opened this issue Sep 17, 2019 · 1 comment · Fixed by #32245
Labels
feature has-pr js v5

Comments

@Johann-S
Copy link
Member

Currently in all of our plugins constructors, the first parameter is an element, we should allow our users to use CSS selector too.

X-Ref: #29416
@Johann-S Johann-S changed the title Allow our constructor to accept a CSS selector Allow our constructors to accept a CSS selector Sep 17, 2019
@rohit2sharma95
Copy link
Collaborator

If the selector returns a node list then the constructor should use just the first element? Or maybe you will use querySelector() always for it. What is your idea? @Johann-S

@rohit2sharma95 rohit2sharma95 mentioned this issue Nov 24, 2020
Merged
@mdo mdo added the has-pr label Jan 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature has-pr js v5
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow constructors to accept a CSS selector rohit2sharma95/bootstrap
3 participants
@mdo @Johann-S @rohit2sharma95