Allow constructors to accept a CSS selector #32245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
|
IMO this PR should move after #29370 |
rohit2sharma95
force-pushed
the
selector-in-constructor
branch
from
d0353f1
to
42f7481
Compare
rohit2sharma95
force-pushed
the
selector-in-constructor
branch
2 times, most recently
from
a2b7fa6
to
ba5446c
Compare
rohit2sharma95
force-pushed
the
selector-in-constructor
branch
from
8b3d339
to
fa045e2
Compare
rohit2sharma95
force-pushed
the
selector-in-constructor
branch
2 times, most recently
from
0c2920b
to
bf74944
Compare
|
@XhmikosR CSS selectors should be added in the code snippets in the docs? |
XhmikosR
reviewed
Jan 10, 2021
XhmikosR
reviewed
Jan 10, 2021
rohit2sharma95
force-pushed
the
selector-in-constructor
branch
from
bf74944
to
1dc0fd3
Compare
rohit2sharma95
force-pushed
the
selector-in-constructor
branch
from
6406262
to
593eb9c
Compare
mdo
reviewed
Feb 19, 2021
|
@rohit2sharma95 @XhmikosR I see this needs docs—anything I can help with? |
mdo
approved these changes
Feb 22, 2021
This was referenced Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview: https://deploy-preview-32245--twbs-bootstrap.netlify.app/
Closes #29417