create a base component

[Johann-S]

Create a base component which will allow us to mutualize logics across our components

TODO:

• switch to toBeInstanceOf
• Move constructor in base component
• Move getInstance in the base component
• Move dispose in base component
• Move VERSION in base component
• Address Remove setData from construtors #32264

Preview: https://deploy-preview-29370--twbs-bootstrap.netlify.app/

[XhmikosR]

This increases the dist files. I'm not sure about any performance impact either.

We should try and get some benchmarks in before going further with this kind of changes IMO...

[Johann-S]

This change doesn't impact perfs, it's just a bit of refactoring to keep our codebase clean. Inheritance is something we already use (Popovers inherit from Tooltip)

[Johann-S]

BTW I plan to add a createInstance method in the base component to allow our users to create instances without using new when they don't need to store an instance

[mdo]

Is this worth revisiting or is it too stale/old?

[Johann-S]

We should investigate a bit more to move the _jQueryInterface inside the BaseComponent

[Johann-S]

@XhmikosR I worked on that and was able to move dispose in the BaseComponent

But currently I don't think we can do more than that, so this PR as ready to be reviewed

[rohit2sharma95]

IMO, this PR now gives benefit to:

1. Allow constructors to accept a CSS selector #32245 (Logic for CSS selectors can be written in BaseComponent)
2. refactor: use a Map instead of an Object in dom/data #32180 (Includes tests for getInstance method)
3. Ability to add listeners directly to objects like Modals/Collapse/etc #32184 (Event listeners can be written in BaseComponent 🤔)

[XhmikosR]

@Johann-S @rohit2sharma95 should we build the base plugin too? Currently it's inlined in each plugin's dist file in js/dist.