Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bootstrap Reboot 4.x CSS contains duplicate text-decoration style for abbr[title] #33197

Closed
matosconsulting opened this issue Feb 24, 2021 · 1 comment · Fixed by #33325
Closed

Comments

@matosconsulting
Copy link

The generated reboot css file contains a duplicate property:

image

bootstrap/scss/_reboot.scss

Lines 145 to 146 in 056216a

text-decoration: underline; // 2
text-decoration: underline dotted; // 2

CSS allows duplicate property names but only the last instance of a duplicated name determines the actual value that will be used for it. Therefore, changing values of other occurrences of a duplicated name will have no effect and may cause misunderstandings and bugs.

  • Operating system and version: All/Unrelated
  • Browser and version: All/Unrelated
  • Suggested Fix: Remove the duplicate that doesn't align with the vision of the product
@ffoodd
Copy link
Member

ffoodd commented Feb 25, 2021

Hi there, thanks for reporting!

It was done on purpose, since text-decoration as a shorthand had very poor support back in the days: the first declaration was a fallback value for non-supporting browsers (which is a very common pattern for progressively enhance some properties allowing modern values).

However after checking support on MDN, it appears that our current targets all support the shorthand value. I think it's now safe to drop the first one in v5 then.

Feel free to suggest a patch, or we'll take of it when possible.

gopal-jayaraman added a commit to gopal-jayaraman/bootstrap that referenced this issue Mar 10, 2021
Removing duplicate text-decoration style for abbr[title] twbs#33197
gopal-jayaraman added a commit to gopal-jayaraman/bootstrap that referenced this issue Mar 10, 2021
Fix: removing duplicate text-decoration style for abbr[title] twbs#33197
mdo pushed a commit that referenced this issue Mar 11, 2021
Removing duplicate text-decoration style for abbr[title] #33197
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants