Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List Group JavaScript behavior : W3C validation error - The aria-controls attribute must point to an element in the same document! #33650

Closed
devhoussam opened this issue Apr 15, 2021 · 7 comments · Fixed by #33664

Comments

@devhoussam
Copy link
Contributor

Image

@ffoodd
Copy link
Member

ffoodd commented Apr 15, 2021

Does it come from our docs?

@mdo
Copy link
Member

mdo commented Apr 15, 2021

Looks like it's in reference to https://getbootstrap.com/docs/5.0/components/list-group/#javascript-behavior. validator.w3.org passes for me though. There are those IDs in the page.

@devhoussam
Copy link
Contributor Author

Does it come from our docs?

yes from the Docs

@devhoussam
Copy link
Contributor Author

passes for me though. There are those IDs in the page.

I use the "JavaScript behavior" Example in List Group Component while I try to validated in W3C Validator it show me this errors!

@ffoodd
Copy link
Member

ffoodd commented Apr 15, 2021

I see, this example's aria-controls need to be prefixed with list- since they should match tabpanels ids.

Feel free to submit a PR if you dare, otherwise we'll fix that later.

@k99sharma
Copy link
Contributor

I tried to solve the issue by adding list- as prefix in aria-controls value. Can you check if it's right or not?

@devhoussam
Copy link
Contributor Author

I tried to solve the issue by adding list- as prefix in aria-controls value. Can you check if it's right or not?

It's Correct try to create a PR

mdo pushed a commit that referenced this issue Apr 17, 2021
Prefixed the `aria-controls` with `list-` to match with `tabpanel`
ids in `Javascript behavior` example in `List Group Component`.
@mdo mdo closed this as completed Apr 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants