Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V5 Heroes example responsive layout issues #33660

Closed
kohheepeace opened this issue Apr 16, 2021 · 1 comment · Fixed by #33681
Closed

V5 Heroes example responsive layout issues #33660

kohheepeace opened this issue Apr 16, 2021 · 1 comment · Fixed by #33681

Comments

@kohheepeace
Copy link
Contributor

kohheepeace commented Apr 16, 2021

I found some issues at heroes examples
https://getbootstrap.com/docs/5.0/examples/heroes/

📌 Issues

1. Image should be centered or stretched for tablet and mobile

issue-1
at "Responsive left-aligned hero with image" example

2. Sign Up form is too narrow for mobile

2021-04-16_23h05_12

at "Vertically centered hero sign-up form" example

📌 Fixed Codesandbox demo

This is a codesandbox demo URL which fixes these issues.
https://9oihf.csb.app

I only added Bootstrap's classes to fix these issues. (*It measns I didn't add custom css)

1. Image should be centered or stretched for tablet and mobile

issue-1-fixed

2. Sign Up form is too narrow for mobile

2021-04-16_23h03_51

PR

If this is an issue that needs to be fixed, I'd like to send a PR.

Thanks !

Environment

  • Operating system and version: Windows
  • Browser and version: Chrome 89.0.4389.114
@kohheepeace kohheepeace changed the title Fix v5 Heroes example responsive layout V5 Heroes example responsive layout issues Apr 16, 2021
@mdo
Copy link
Member

mdo commented Apr 19, 2021

Leaving the image as-is, but will fix the sign up form for sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants