Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

when using bg-dark text is disappeared #38430

Closed
3 tasks done
niirdan opened this issue Apr 9, 2023 · 3 comments
Closed
3 tasks done

when using bg-dark text is disappeared #38430

niirdan opened this issue Apr 9, 2023 · 3 comments

Comments

@niirdan
Copy link

niirdan commented Apr 9, 2023

Prerequisites

Describe the issue

Good Evening Guys ! ,
I Found This Old issue :
#36096
which I Suffer the Exact same bug in The New V 5.3.0
When using bg-dark & texted-muted Text vanishes

  • same problem when I remove the 'text-muted'
    I Solved it By Downgrading to V 5.2.3
    Please let me know if picture's from my project for the bug is necessarily (the pictures in the old issue is exactly the same problem that I suffer)

Reduced test cases

Downgrading to V 5.2.3 "Solved" it ..

What operating system(s) are you seeing the problem on?

Windows, macOS, Android, iOS, Linux

What browser(s) are you seeing the problem on?

Chrome, Safari

What version of Bootstrap are you using?

v5.3.0

@mdo
Copy link
Member

mdo commented Apr 9, 2023

This is covered in our docs—we have new .text-body-* classes to do color mode friendly text colors.

@mdo mdo closed this as not planned Won't fix, can't repro, duplicate, stale Apr 9, 2023
@mdo mdo removed this from v5.3.0-stable Apr 9, 2023
@mdo
Copy link
Member

mdo commented Apr 9, 2023

That is, unless we want to revert part of #37890. Thoughts @julien-deramond?

@julien-deramond
Copy link
Member

julien-deramond commented Apr 9, 2023

This is covered in our docs—we have new .text-body-* classes to do color mode friendly text colors.

This is but still, https://twbs-bootstrap.netlify.app/docs/5.3/components/navbar/#external-content is broken in light mode: the "Toggleable via the navbar brand." text is not visible.

Regarding this issue, in https://twbs-bootstrap.netlify.app/docs/5.3/components/navbar/#color-schemes we are using data-bs-theme="dark" in combination with .bg-dark.
So in https://twbs-bootstrap.netlify.app/docs/5.3/components/navbar/#external-content, in order to display correctly "Toggleable via the navbar brand." in all cases, we could use data-bs-theme="dark" as well since .bg-dark is forced for this example in light and dark mode.
No need to change the rest of the content nor to reintegrate .text-muted which we should keep deprecated.
Edit: See #38431

Another possibility would be to drop this use of .bg-dark here which is not very useful since we are talking here about "External content" and not the colors. And so prefer the usage of .bg-body-tertiary (like the other examples on this page).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants