Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: fix text rendering of navbar external content #38431

Merged
merged 1 commit into from
Apr 10, 2023

Conversation

julien-deramond
Copy link
Member

@julien-deramond julien-deramond commented Apr 10, 2023

Description

Reference: #38430 (comment)

Before this PR, in https://twbs-bootstrap.netlify.app/docs/5.3/components/navbar/#external-content, when you click on the toggle button, "Toggleable via the navbar brand." is not visible because written with the same color as the background.

Screenshot 2023-04-10 at 09 04 23

This is due to the fact that .text-muted is deprecated and has been changed by .text-body-emphasis.
In light mode, .text-body-emphasis will have the same color as .bg-dark.
Based on what's explained in https://twbs-bootstrap.netlify.app/docs/5.3/components/navbar/#color-schemes, we can simply use data-bs-theme="dark" combined with the .bg-dark to keep using .text-body-emphasis. But we should also rather use .text-body-emphasis for the white color.

Another possibility to fix this issue would be to avoid using a dark navbar here since the content is not linked to this specific color, we could have a light background to explain this feature.

Type of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • (N/A) I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

#38430

@julien-deramond julien-deramond marked this pull request as ready for review April 10, 2023 07:11
@mdo mdo merged commit e831121 into main Apr 10, 2023
@mdo mdo deleted the main-jd-fix-text-rendering-navbar-ext-content branch April 10, 2023 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants