Docs: fix text rendering of navbar external content #38431
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reference: #38430 (comment)
Before this PR, in https://twbs-bootstrap.netlify.app/docs/5.3/components/navbar/#external-content, when you click on the toggle button, "Toggleable via the navbar brand." is not visible because written with the same color as the background.
This is due to the fact that
.text-muted
is deprecated and has been changed by.text-body-emphasis
.In light mode,
.text-body-emphasis
will have the same color as.bg-dark
.Based on what's explained in https://twbs-bootstrap.netlify.app/docs/5.3/components/navbar/#color-schemes, we can simply use
data-bs-theme="dark"
combined with the.bg-dark
to keep using.text-body-emphasis
. But we should also rather use.text-body-emphasis
for the white color.Another possibility to fix this issue would be to avoid using a dark navbar here since the content is not linked to this specific color, we could have a light background to explain this feature.
Type of changes
Checklist
npm run lint
)Live previews
Related issues
#38430