Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@btnBorder variable has no effect #6474

Closed
hamishcampbell opened this issue Jan 7, 2013 · 1 comment
Closed

@btnBorder variable has no effect #6474

hamishcampbell opened this issue Jan 7, 2013 · 1 comment
Labels
Milestone

Comments

@hamishcampbell
Copy link

See the comment:

b979cd9#commitcomment-2373976

button border color (@btnBorder) is always overridden by the reset. .btn border-color is first set to #c5c5c5 then second directive with transparency is applied.

Seems that @btnBorder should be updated to #c5c5c5 and the extra .btn border reset removed, but that would subtly change the existing button border.

My current hack is to add this to my build:

.btn {
  border-color: @btnBorder;
  border-bottom-color: darken(@btnBorder, 10%);
};

Issues seems fairly self-evident from buttons.less, but let me know if I need a more detailed test case.

@mdo
Copy link
Member

mdo commented Jan 12, 2013

Fixed in #6346. Thanks!

@mdo mdo closed this as completed Jan 12, 2013
stempler pushed a commit to stempler/bootstrap that referenced this issue Apr 11, 2014
stempler pushed a commit to stempler/bootstrap that referenced this issue Nov 4, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants