Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

table-bordered doesn't round corners for tbody th #6538

Closed
adam-iris opened this issue Jan 11, 2013 · 1 comment
Closed

table-bordered doesn't round corners for tbody th #6538

adam-iris opened this issue Jan 11, 2013 · 1 comment
Labels
Milestone

Comments

@adam-iris
Copy link

<th> is valid inside <tbody> -- it appears in the spec examples at http://www.w3.org/TR/html5/tabular-data.html#examples, and Bootstrap includes a selector for it to remove the double top-border:

  tbody:first-child tr:first-child th,

But the rest of the selectors ignore it. For example:

  // For first th or td in the last row in the last thead or tbody
  thead:last-child tr:last-child > th:first-child,
  tbody:last-child tr:last-child > td:first-child,
  tfoot:last-child tr:last-child > td:first-child {
    .border-bottom-left-radius(@baseBorderRadius);
  }

I believe that this should have an additional selector:

  tbody:last-child tr:last-child > th:first-child,

I think all the other border radius selectors in table-bordered have the same issue.

@mdo
Copy link
Member

mdo commented Jan 12, 2013

Added to #6346. Next time consider a quick pull request to get your name on those lines. Thanks!

@mdo mdo closed this as completed Jan 12, 2013
stempler pushed a commit to stempler/bootstrap that referenced this issue Apr 11, 2014
stempler pushed a commit to stempler/bootstrap that referenced this issue Nov 4, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants