Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forcing h3 within topbar is bad practice #90

Closed
danspam opened this issue Aug 26, 2011 · 9 comments
Closed

Forcing h3 within topbar is bad practice #90

danspam opened this issue Aug 26, 2011 · 9 comments
Milestone

Comments

@danspam
Copy link

danspam commented Aug 26, 2011

Heading tags are supposed to follow each other in descending order, starting from H1. The styles for the topbar are forcing you to use an H3 tag in the header before any other heading tags. Perhaps this should be changed to a class so that you can use whichever tag you want for the website name.

@mdo
Copy link
Member

mdo commented Sep 2, 2011

I've used the h3 since it provides some level of styling with and without the CSS applied. This makes a quick little hierarchy in the topbar before the page's started H1 and provides a label above nav that is larger than typical nav links. Make sense?

@fauzias
Copy link

fauzias commented Sep 5, 2011

I'd like to propose the tag for putting an images/logo also in the topleft bar, since lastly i've had to hack around to get the logo properly fit alongside the heading title

@harrybailey
Copy link

I agree with danspam. Replacing the h3 with a class or <strong> tag would by more semantic.

@vonkohorn
Copy link

fauziassegaff -- images/logo aligns pretty nicely if you also put it inside an h3 tag.

@fauzias
Copy link

fauzias commented Sep 10, 2011

vonkohorn -- i did, but it's just feel improperly to put it there, i'd much prefer putting it in it's on span/div with logo class, one of the reason also is sometimes we want to put the logo overalapping the component of h3 itself

@mdo
Copy link
Member

mdo commented Sep 10, 2011

Filing this under v2.0.0 for now since we'll have to change classes. We might be able to do it now with 1.3-wip and support the old stuff, but we'll see.

@mdo
Copy link
Member

mdo commented Sep 10, 2011

Welp, that was easy :).

Starting in 1.3, we'll have .brand in the topbar in addition to the h3 tag. With v2, we'll remove the h3 and other legacy cruft.

Why .brand? Because "logo" implies a graphical treatment of something whereas "brand" can be a word, an image, or both.

Thanks guys!

@mdo mdo closed this as completed Sep 10, 2011
@harrybailey
Copy link

Great. Currently it's .container > h3 > a What will it be from v2?

.container > span > a
.container > p > a

?

@mdo
Copy link
Member

mdo commented Sep 12, 2011

In 1.3-wip and 2.0, it will be .brand a.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants