-
-
Notifications
You must be signed in to change notification settings - Fork 78.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Forcing h3 within topbar is bad practice #90
Comments
I've used the h3 since it provides some level of styling with and without the CSS applied. This makes a quick little hierarchy in the topbar before the page's started H1 and provides a label above nav that is larger than typical nav links. Make sense? |
I'd like to propose the tag for putting an images/logo also in the topleft bar, since lastly i've had to hack around to get the logo properly fit alongside the heading title |
I agree with danspam. Replacing the h3 with a class or <strong> tag would by more semantic. |
fauziassegaff -- images/logo aligns pretty nicely if you also put it inside an h3 tag. |
vonkohorn -- i did, but it's just feel improperly to put it there, i'd much prefer putting it in it's on span/div with logo class, one of the reason also is sometimes we want to put the logo overalapping the component of h3 itself |
Filing this under v2.0.0 for now since we'll have to change classes. We might be able to do it now with 1.3-wip and support the old stuff, but we'll see. |
Welp, that was easy :). Starting in 1.3, we'll have Why .brand? Because "logo" implies a graphical treatment of something whereas "brand" can be a word, an image, or both. Thanks guys! |
Great. Currently it's .container > h3 > a What will it be from v2? .container > span > a ? |
In 1.3-wip and 2.0, it will be |
…specified display mode for IE6. fixes twbs#90
Reorg @Viewport now that we don't need to worry about non-responsiveness
Heading tags are supposed to follow each other in descending order, starting from H1. The styles for the topbar are forcing you to use an H3 tag in the header before any other heading tags. Perhaps this should be changed to a class so that you can use whichever tag you want for the website name.
The text was updated successfully, but these errors were encountered: