Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modal shown event fires too early? #9579

Closed
SimonG04 opened this issue Aug 15, 2013 · 2 comments
Closed

Modal shown event fires too early? #9579

SimonG04 opened this issue Aug 15, 2013 · 2 comments
Labels

Comments

@SimonG04
Copy link

In an attempt to embed a remote page inside of a bootstrap modal I needed to use the "shown.bs.modal" event to know when to resize a slideshow within my external html once the modal had loaded. This "shown.bs.modal" event worked fine for me in 3 RC1 but since switching over to RC2 it is no longer working as expected.

As a test I wrote a small setTimeout function to keep checking the body for the "modal-open" class as a way of determining when the modal had actually fully opened and then resized my slideshow based on that. This is fine but shouldnt the "shown.bs.modal" event only fire once the modal has fully finished loading (i.e. once the body has the "modal-open" class)?

I've made an example of what I did here:
http://codepen.io/anon/pen/wusak
(scroll down to the bottom of the JS window to see my button code)

@Merg1255
Copy link

possibly linked: #9419

@fat
Copy link
Member

fat commented Aug 17, 2013

yep - good catch, thanks!

@fat fat closed this as completed Aug 17, 2013
fat added a commit that referenced this issue Aug 17, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants