Quotes #10709
Quotes #10709
Conversation
|
Per the Bootstrap JavaScript code style guidelines, semicolons should not be used. |
|
I missed that, it seems. I'll update the PR. |
| @@ -34,6 +34,9 @@ module.exports = function(grunt) { | |||
| }, | |||
| test: { | |||
| src: ['js/tests/unit/*.js'] | |||
| }, | |||
| assets: { | |||
There was a problem hiding this comment.
Explanation? This isn't quote-related.
There was a problem hiding this comment.
I added the Bootstrap files from the assets folder in the JSHint task.
There was a problem hiding this comment.
Moved this patch to my other PR so that this PR has only the quotes change.
|
👍 |
|
Any news on this? |
|
@cvrebert ping 2013/9/25 XhmikosR notifications@github.com
Zlatan Vasović - ZDroid |
|
This is in @fat's domain. |
|
Oh, yea. But I think that this can be merged, because jQuery styleguide 2013/9/25 Chris Rebert notifications@github.com
Zlatan Vasović - ZDroid |
|
Gah, misclicked. |
|
:/ 2013/9/25 Chris Rebert notifications@github.com
Zlatan Vasović - ZDroid |
|
PR rebased. |
|
@XhmikosR Two core faults in your pull requests are:
|
|
I don't have a preference; it's just that atm quotes aren't being used consistently. That's what this patch is for. |
|
Based on the number of changes, it looks like the double quotes are used more than single quotes. Thanks, but we'll leave as-is and can update the single quotes in a separate PR. |
|
@mdo: quite the opposite. Single quotes are used in the codebase, that's why I went with it. |
|
@mdo: Rebased against the latest master. |
No description provided.