removed all caret border color settings. #11642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Shall I add the new builded files in |
|
Yes please. |
|
Holy shit yes. I had a feeling I should have looked into this more—I absolutely hated having to write all that CSS. Thanks for the heads up! |
mdo
added a commit
that referenced
this pull request
Nov 28, 2013
removed all caret border color settings.
This was referenced Nov 28, 2013
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In most cases,
caretcolor should be same as text color.You tried to get this by setting border-color in many places to the color of text. But not in all cases. For instance for buttons with other state than the default state, it is set to
#fffinstead of using color-variables of states and handling for:hoverI missing completely.But for what all this overhead?
Why you do not use the default behavior of border-color? The default is, if it is not specified, the text color will be used. And that is exact what we want, isn't?
In this pull request I removed all the border-color setting for
caret.Please give it a try.
It would simplify the Bootstrap CSS and give everybody the chance, to set a caret color by simply set the
colorproperty for class.caret.