Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minify css with clean-css #11778

Closed
wants to merge 1 commit into from
Closed

Minify css with clean-css #11778

wants to merge 1 commit into from

Conversation

XhmikosR
Copy link
Member

@XhmikosR XhmikosR commented Dec 8, 2013

The reasons for this change are:

  1. better compression
  2. clean-css works around a couple of old IE issues like the one which needs a space after comma in filter properties (hence bootstrap-theme.min is bigger with clean-css)
  3. clean-css is in active development and next thing is to improve selectors merging so compression should improve even more

For bootstrap.min.css

102.931 master.css
100.728 clean-css.css

/CC @mdo

@mdo
Copy link
Member

mdo commented Dec 8, 2013

Nice, sounds good to me. @cvrebert Feedback?

@cvrebert
Copy link
Collaborator

cvrebert commented Dec 8, 2013

Might as well switch from RECESS to grunt-contrib-less then. It supports less v1.5 and clean-css-based minification.

@mdo
Copy link
Member

mdo commented Dec 8, 2013

Was thinking about that, too. Let's look into that for sure.

@XhmikosR
Copy link
Member Author

XhmikosR commented Dec 8, 2013

I haven't used grunt-contrib-less, but if it supports both I guess it makes more sense to switch to that.

@mdo
Copy link
Member

mdo commented Dec 9, 2013

@XhmikosR @cvrebert The only problem is we'd lose some of the niceties that Recess provides:

  • Proper alignment of prefixed properties
  • Property order

Those are pretty huge to me, so I'm unsure about pushing forward on it. If that stuff is configurable, I'm super down. Otherwise might not work out. Anyway, enough diversion for this PR—let's talk about this more elsewhere if someone wants to start in on it.

@acmetech
Copy link
Contributor

acmetech commented Dec 9, 2013

@mdo, these may help. https://github.com/csscomb/csscomb.js and https://github.com/csscomb/grunt-csscomb

Proper alignment of prefixed properties

https://github.com/csscomb/csscomb.js#vendor-prefix-align

I've never used the above, only the plugin for Sublime Text.

@mdo
Copy link
Member

mdo commented Dec 9, 2013

Merged into #11790.

@mdo mdo closed this Dec 9, 2013
mdo added a commit that referenced this pull request Dec 9, 2013
@XhmikosR XhmikosR deleted the clean-css branch December 10, 2013 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants