Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #12124 #12263

Closed
wants to merge 1 commit into from
Closed

Fixes #12124 #12263

wants to merge 1 commit into from

Conversation

watilde
Copy link
Contributor

@watilde watilde commented Jan 16, 2014

Fixes #12124
Remove border-bottom-radius when .table was putted before .panel-footer in .panel

current: http://jsfiddle.net/jcQhm/1/
my fixed: http://jsfiddle.net/zjjus/

@mdo
Copy link
Member

mdo commented Jan 17, 2014

That selector isn't supported by IE8.

@mdo mdo closed this Jan 17, 2014
@watilde
Copy link
Contributor Author

watilde commented Jan 17, 2014

Thanks for your comment. I just updated. 2ddc1df023931dc96490094a0e8677fca21a056c

@mdo
Copy link
Member

mdo commented Jan 17, 2014

Open ended :last-child selectors aren't going to fly either I'm afraid.

@watilde
Copy link
Contributor Author

watilde commented Jan 17, 2014

Sorry, it’s me again. That was probably correct my pull request at first. #12124

So I've updated this branch.

@watilde
Copy link
Contributor Author

watilde commented Jan 18, 2014

Could you please review once more? @mdo

@mdo
Copy link
Member

mdo commented Jan 18, 2014

Looks good now, @watilde. Can you also make the appropriate change to the list groups in panels? They'll need the :last-child on .list-group. Open a new pull request with those changes and I'll get them into v3.1.

Thanks for following up so hard <3.

mdo added a commit that referenced this pull request Jan 18, 2014
Fixes #12263: Remove border radius when it's not both ends in panel
stempler pushed a commit to stempler/bootstrap that referenced this pull request Apr 11, 2014
Fixes twbs#12263: Remove border radius when it's not both ends in panel
stempler pushed a commit to stempler/bootstrap that referenced this pull request Nov 4, 2014
Fixes twbs#12263: Remove border radius when it's not both ends in panel
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants