Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add examples/css in the csslint task. #12466

Merged
merged 2 commits into from
Feb 4, 2014
Merged

Add examples/css in the csslint task. #12466

merged 2 commits into from
Feb 4, 2014

Conversation

XhmikosR
Copy link
Member

Fixes #12457.

@XhmikosR
Copy link
Member Author

BTW most issues are because of the order of properties. Maybe csscomb should be used for these css files too?

@XhmikosR
Copy link
Member Author

@cvrebert: see here for the csscomb change. I can make a PR after this is merged if you want.

@cvrebert
Copy link
Collaborator

I think the position of the filter might be intentional.

@cvrebert
Copy link
Collaborator

/to @mdo for review

@XhmikosR
Copy link
Member Author

Not sure about that, I generally place it after all the other normal properties like it's in the patch.

Even with csscomb and the current config used it's placed there.

@mdo
Copy link
Member

mdo commented Jan 31, 2014

The placement of filter after background-image is intended.

@XhmikosR
Copy link
Member Author

@mdo: using the current csscomb config from the repo you can see the change.

https://github.com/XhmikosR/bootstrap/compare/examples-csscomb#diff-945816d86d91c9ad1cb91a042b7c6b96R42

@mdo
Copy link
Member

mdo commented Jan 31, 2014

I see that line being unaffected. I'm confused, why was filter brought up in the first place? This diff looks fine to me btw.

@XhmikosR
Copy link
Member Author

@mdo: @cvrebert brought it up because of this

The other link above proves that this is how it would be if csscomb was used too.

@mdo
Copy link
Member

mdo commented Jan 31, 2014

Ah, well, that change makes sense, too. Diff looks good.

@XhmikosR
Copy link
Member Author

XhmikosR commented Feb 1, 2014

So, you could merge it I guess :D

mdo added a commit that referenced this pull request Feb 4, 2014
Add examples/css in the csslint task.
@mdo mdo merged commit 9ba4942 into twbs:master Feb 4, 2014
@mdo mdo mentioned this pull request Feb 4, 2014
1 task
@mdo
Copy link
Member

mdo commented Feb 4, 2014

<3

@XhmikosR XhmikosR deleted the 12457 branch February 4, 2014 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

some of the example templates fail csslint
3 participants