reuse popover variables to set popover arrow colors. #12674
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stempler
pushed a commit
to stempler/bootstrap
that referenced
this pull request
Apr 11, 2014
* The problem with twbs#12674 is that it reassigns the same variable, but the color values were purposely different. * This uses Less's color functions to generate the proper darker colors. * Why darker colors? Because those CSS carets render lighter than their solid border counterparts. Consider it a design hack.
stempler
pushed a commit
to stempler/bootstrap
that referenced
this pull request
Nov 4, 2014
* The problem with twbs#12674 is that it reassigns the same variable, but the color values were purposely different. * This uses Less's color functions to generate the proper darker colors. * Why darker colors? Because those CSS carets render lighter than their solid border counterparts. Consider it a design hack.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The arrow of a popover should often look like a fin of the box with same background and border color.
So I suggest to reuse this values to specify the arrow values.
IMHO it makes also more clear for what this variables are standing for.