Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modular the mixins #12998

Merged
merged 9 commits into from
Mar 10, 2014
Merged

Modular the mixins #12998

merged 9 commits into from
Mar 10, 2014

Conversation

mrmrs
Copy link
Contributor

@mrmrs mrmrs commented Mar 10, 2014

Definitely need some other eyes on this. I'm pretty open to changing whatever. But this seems like a good first stab at breaking up that monolithic mixing file.

mrmrs added 2 commits March 9, 2014 23:18
Move all deprecated vendor prefix mixins to less/mixins/vendor-prefixes.less
Create mixins directory and move partials to that directory.

FIXES #12994
* master:
  Replace some images on the Carousel example with some base64 encoded 1x1 gifs
  ugh grunt
  moar grunt
  mo copy
  http://www.youtube.com/watch?v=AJWtLf4-WWs
  grunt
  Copy change
  fix grammar in comment in forms.less
  Fixes #12759
  Fixes #12738
  replace .visible-{size} with .visible-{size}-{display} ; fixes #8869

Conflicts:
	dist/css/bootstrap-theme.css.map
	dist/css/bootstrap.css.map
	docs/assets/js/customize.min.js
	docs/assets/js/raw-files.min.js
	docs/dist/css/bootstrap-theme.css.map
	docs/dist/css/bootstrap.css.map
	less/mixins.less
@mdo mdo added the css label Mar 10, 2014
@mdo mdo added this to the v3.2.0 milestone Mar 10, 2014




Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need only one new line.


// Animations
//
// Deprecated as of v3.2.0 due to the introduction of autoprefixer (will be removed in v4)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we should consolidate all of the deprecation notices here into one "this entire file is deprecated" notice?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dig that.

@mdo mdo mentioned this pull request Mar 10, 2014
@mrmrs
Copy link
Contributor Author

mrmrs commented Mar 10, 2014

@cvrebert @mdo - I do say "These are deprecated mixins that handle vendor prefixes" at the top of the file but we can be more explicit if you want.

Also - just nuked the toc in mixins.less

mdo added a commit that referenced this pull request Mar 10, 2014
@mdo mdo merged commit 82e2f87 into master Mar 10, 2014
@mdo mdo deleted the modular-the-mixins branch March 10, 2014 23:36
@mdo mdo mentioned this pull request Mar 10, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants