Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue using Collapse without Panel #13275

Closed
wants to merge 1 commit into from
Closed

Fix issue using Collapse without Panel #13275

wants to merge 1 commit into from

Conversation

zessx
Copy link

@zessx zessx commented Apr 4, 2014

Overview

If you try to use Collapse without Panel, you must use the .panel class to get it work.

Example

<div id="accordion">
  <div>
    <a data-toggle="collapse" data-parent="#accordion" href="#collapseOne">Item #1</a>
    <div id="collapseOne" class="collapse in">
      Lorem Ipsum
    </div>
  </div>
  <div>
    <a data-toggle="collapse" data-parent="#accordion" href="#collapseTwo">Item #2</a>
    <div id="collapseTwo" class="collapse">
      Lorem Ipsum
    </div>
  </div>
  <div>
    <a data-toggle="collapse" data-parent="#accordion" href="#collapseThree">Item #3</a>
    <div id="collapseThree" class="collapse">
      Lorem Ipsum
    </div>
  </div>
</div>

Expected behavior

On Item #2 click, we expect the first block (under Item #1) to collapse, and the second one (under Item #2) to extend.

Current behavior

On Item #2 click, and the second block (under Item #2) extends. The first block (under Item #1) doesn't collapse.

@cvrebert cvrebert added the js label Apr 4, 2014
@cvrebert
Copy link
Collaborator

cvrebert commented Apr 4, 2014

Duplicate of #10966.
This particular change rejected per #10966 (comment)

@cvrebert cvrebert closed this Apr 4, 2014
@zessx zessx deleted the patch-1 branch June 5, 2014 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants