fires closed.bs.alert *after* DOM detach() as per #12379 #13406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fires closed.bs.alert *after* element is removed from DOM. Previously it fired while the element was still attached.
|
👍 |
| @@ -42,7 +42,7 @@ | |||
| $parent.removeClass('in') | |||
|
|
|||
| function removeElement() { | |||
| $parent.trigger('closed.bs.alert').remove() | |||
| $parent.detach().trigger('closed.bs.alert') | |||
There was a problem hiding this comment.
Please add a .remove() at the end, per #12379 (comment)
There was a problem hiding this comment.
NAVER - http://www.naver.com/
lee36656@naver.com 님께 보내신 메일 <Re: [bootstrap] fires closed.bs.alert after DOM detach() as per #12379 (#13406)> 이 다음과 같은 이유로 전송 실패했습니다.
받는 사람이 회원님의 메일을 수신차단 하였습니다.
Added call to remove() after event fires to clean up data as per discussion at twbs#12379
|
/to @fat for final review. |
|
lgtm |
|
thanks! |
cvrebert
added a commit
that referenced
this pull request
May 6, 2014
fires closed.bs.alert *after* DOM detach() as per #12379
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per #12379
Fires closed.bs.alert after element is removed from DOM.
Previously it fired while the element was still attached.