place feedback icon lower, only if it really need #14005
Conversation
| .has-feedback label.sr-only ~ .form-control-feedback { | ||
| top: 0; | ||
| // Reposition feedback icon if input has visible label above | ||
| .has-feedback label:not(.sr-only) ~ .form-control-feedback { |
There was a problem hiding this comment.
:not() isn't supported by IE8...
There was a problem hiding this comment.
@cvrebert, oh sorry.
Work around it by additional rule
|
Have a jsbin or something to demo the before and after? |
|
@mdo |
|
Hi @just-boris! You appear to have posted a live example (http://jsbin.com/hiqiyomu/1), which is always a good first step. However, according to the HTML5 validator, your example has some validation errors, which might be causing your issue:
You'll need to fix these errors and post a revised example before we can proceed further. (Please note that this is a fully automated comment.) |
|
Hi @just-boris! You appear to have posted a live example (http://jsbin.com/hiqiyomu/2), which is always a good first step. However, according to the HTML5 validator, your example has some validation errors, which might be causing your issue:
You'll need to fix these errors and post a revised example before we can proceed further. (Please note that this is a fully automated comment.) |
|
Fixed examples: |
|
This fix is important to me because I want to make an multi-value editor. In this case I have a single common label and many inputs representing each item in list. |
|
Updated example with all your stuff and a few more tweaks to remove some unnecessary CSS after your changes: http://jsbin.com/hiqiyomu/8. |
Now you have default space from top, and remove when if label is hidden.
If it will be changed like this, feedback-icon would be placed correctly even if the label is omitted.