-
-
Notifications
You must be signed in to change notification settings - Fork 78.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate the remote
option of modals?
#14034
Conversation
Follow-up to #13087 (comment) Closes #13087 as WONTFIX. Closes #13597 as WONTFIX.
[skip sauce]
remote
option of modalsremote
option of modals?
I'll also leave some feedback: I think this is the right way to go. As was stated previously, the |
Yeah, that'd probably be good. I'd want to also add some link about client-side templating. |
yep, this sounds good to me. I think both ideas about giving people jumping off points if they want to go that route sound good 👍 |
…rnatives [skip sauce]
Deprecate the `remote` option of modals?
@hnrch02 How about |
@mbrodala I adopted |
remote
)remote
doesn't currently give any "loading..." (or similar) visual indication while the network request is in-progress, and doesn't fire any "loading started" eventremote
doesn't currently give any visual indication or fire any event when the network request failsremote
can discourage the use of client-side templating, even when it might be a preferable option.So, I think we have 3 options:
remote
modals.remote
modals.remote
modals in a somewhat half-assed state.CC: @fat @twbs/team for discussion