Add role="tablist" to .nav-pills in examples to improve accessibility #14070
+17
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cvrebert
added a commit
that referenced
this pull request
Jul 8, 2014
Add role="tablist" to .nav-pills in examples to improve accessibility
Closed
|
😻 |
|
Refs #13554. |
|
Just a note that this addition may not actually be accurate (currently discussing this with PayPal folks, but in short: unless .nav-pills (and .nav-tabs for that matter) are actually used for a tabbed navigation (where content is shown/hidden in a classic tab, rather than used as a visual way to present a navigation to other pages), role="tablist" is wrong and against ARIA spec. See paypal/bootstrap-accessibility-plugin#59 |
|
X-Ref: #14951 |
|
and apologies...on re-reading the above i sound rather crabby. not intended. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to e9374c0
Per paypal/bootstrap-accessibility-plugin@f203dea
Credit: https://github.com/paypal/bootstrap-accessibility-plugin & @rohk