-
-
Notifications
You must be signed in to change notification settings - Fork 79k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update JS Bin template in CONTRIBUTING.md #14111
Conversation
/cc @jdorfman about BootstrapCDN's |
It's only for |
@youngtaek I really hate you and your email provider right now.. |
@cvrebert It's not only you... |
To make debugging easier, it's probably better not to use the minified code. |
The updated template I posted uses the unminified files. |
@juthilo fixing now. |
@jdorfman No worries, thanks for the quick fix! |
The current bug report guidelines are at https://github.com/twbs/bootstrap/blob/master/CONTRIBUTING.md#bug-reports |
Also, the bin is missing the viewport meta tag and the |
It might be worth considering including the IE10 viewport hack too: |
Then we'd also need to include the HTML5 shim and Respond.js. |
🤘 Good catch. It should really be based upon the basic getting started template. |
Bad news, the validation fails for the |
@hnrch02 It's being overly pedantic, just ignore that. LMVTFY specifically allows |
Mkay, will update the PR. |
Should I include the IE10 viewport bug workaround? |
For the example:
Once set, then we can merge. |
Looks good. |
Okay, done. |
Update JS Bin template in CONTRIBUTING.md
Refs: #14109
Link: http://jsbin.com/zazif/1/edit?html,output
That bin still refers to https://github.com/necolas/issue-guidelines for bug reporting guidelines, is that still valid?
Also, I switched to using a CDN for the Bootstrap files, as @cvrebert mentioned a couple of times that we don't endorse hotlinking to getbootstrap.com
The reason why I chose jsDelivr over BootstrapCDN is that they actually have a up-to-date
/latest/
version. (See jsDelivr and BootstrapCDN.)/cc @cvrebert