Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use closest .alert for alert dismissal; closes #14306 #14316

Merged
merged 1 commit into from
Aug 15, 2014

Conversation

hnrch02
Copy link
Collaborator

@hnrch02 hnrch02 commented Aug 4, 2014

Refs #14306

Also updates two alert unit tests which were using incredibly outdated markup. (.alert-message was v1, right?)

/cc @cvrebert @fat

@cvrebert cvrebert added the js label Aug 4, 2014
@cvrebert cvrebert added this to the v3.2.1 milestone Aug 4, 2014
@hnrch02
Copy link
Collaborator Author

hnrch02 commented Aug 5, 2014

(Travis failure is unrelated, see Medium/phantomjs#209.)

@cvrebert
Copy link
Collaborator

Merging per #14306 (comment)

cvrebert added a commit that referenced this pull request Aug 15, 2014
Use closest `.alert` for alert dismissal; closes #14306
@cvrebert cvrebert merged commit 8194668 into twbs:master Aug 15, 2014
@hnrch02 hnrch02 deleted the use-closest-alert branch August 15, 2014 18:30
@cvrebert
Copy link
Collaborator

(Note: This doesn't seem to be responsible for breaking the build; looks like Sauce is just timing out lately across the board: https://travis-ci.org/twbs/bootstrap/jobs/32664008 )

@cvrebert cvrebert mentioned this pull request Aug 23, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants