Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make affix accept 0 as offsetTop or offsetBottom #14363

Closed
wants to merge 1 commit into from

Conversation

samme
Copy link

@samme samme commented Aug 9, 2014

Don't ignore data-offset-top=0 data-offset-bottom=0
Fixes #12815.

Don't ignore `data-offset-top=0` `data-offset-bottom=0`
@cvrebert cvrebert added the js label Aug 9, 2014
@cvrebert cvrebert added this to the v3.2.1 milestone Aug 9, 2014
@hnrch02 hnrch02 changed the title Fix #12815 Make affix accept 0 as offsetTop or offsetBottom Sep 8, 2014
@hnrch02 hnrch02 closed this in e29c750 Sep 8, 2014
@cvrebert cvrebert mentioned this pull request Sep 8, 2014
Saranya-Raaj pushed a commit to Saranya-Raaj/bootstrap that referenced this pull request Oct 9, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

offset-top=0 and offset-bottom=0 don't work on affix plugin via data attributes
2 participants