Fix grunt dist under Bower by separating docs into separate task
#14394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 Emoji hype! 👍 on the changes. |
|
Confirming that this fixes the issue: $ bower install bootstrap#gruntfile-bower
bower bootstrap#gruntfile-bower not-cached git://github.com/twbs/bootstrap.git#gruntfile-bower
bower bootstrap#gruntfile-bower resolve git://github.com/twbs/bootstrap.git#gruntfile-bower
bower bootstrap#gruntfile-bower checkout gruntfile-bower
bower bootstrap#gruntfile-bower resolved git://github.com/twbs/bootstrap.git#06c4002019
bower jquery#>= 1.9.0 cached git://github.com/jquery/jquery.git#2.1.1
bower jquery#>= 1.9.0 validate 2.1.1 against git://github.com/jquery/jquery.git#>= 1.9.0
bower bootstrap#gruntfile-bower install bootstrap#06c4002019
bower jquery#>= 1.9.0 install jquery#2.1.1
bootstrap#06c4002019 bower_components/bootstrap
└── jquery#2.1.1
jquery#2.1.1 bower_components/jquery
$ cd bower_components/bootstrap
$ npm install
<snip>
$ grunt dist
Running "clean:dist" (clean) task
>> 1 path cleaned.
Running "less:compileCore" (less) task
File dist/css/bootstrap.css.map created.
File dist/css/bootstrap.css created: 134.54 kB → 134.58 kB
Running "less:compileTheme" (less) task
File dist/css/bootstrap-theme.css.map created.
File dist/css/bootstrap-theme.css created: 17.93 kB → 17.98 kB
Running "autoprefixer:core" (autoprefixer) task
File dist/css/bootstrap.css created.
File dist/css/bootstrap.css.map created (source map).
Running "autoprefixer:theme" (autoprefixer) task
File dist/css/bootstrap-theme.css created.
File dist/css/bootstrap-theme.css.map created (source map).
Running "usebanner:files" (usebanner) task
✔ grunt-banner completed successfully
Running "csscomb:dist" (csscomb) task
>> Using custom config file "less/.csscomb.json"...
>> Sorting file "dist/css/bootstrap-theme.css"...
>> Sorting file "dist/css/bootstrap.css"...
Running "cssmin:minifyCore" (cssmin) task
File dist/css/bootstrap.min.css created: 135.87 kB → 112.48 kB
Running "cssmin:minifyTheme" (cssmin) task
File dist/css/bootstrap-theme.min.css created: 21.45 kB → 18.93 kB
Running "copy:fonts" (copy) task
Copied 4 files
Running "concat:bootstrap" (concat) task
File dist/js/bootstrap.js created.
Running "uglify:core" (uglify) task
Done, without errors.
Execution Time (2014-08-15 17:47:54 UTC)
less:compileCore 1.2s ▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇ 29%
less:compileTheme 96ms ▇▇▇▇ 2%
autoprefixer:core 691ms ▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇ 18%
autoprefixer:theme 96ms ▇▇▇▇ 2%
csscomb:dist 1.5s ▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇ 37%
uglify:core 385ms ▇▇▇▇▇▇▇▇▇▇▇▇▇▇ 10%
Total 3.9s
$ |
cvrebert
added a commit
that referenced
this pull request
Aug 15, 2014
Fix `grunt dist` under Bower by separating docs into separate task
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13949.
Also does some refactoring.
CC: @twbs/team
👊
🐦 🔫
✊