Handle lack of .width and .height from getBoundingClientRect() in IE8 #14492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cvrebert
force-pushed
the
ie8-getBoundingClientRect
branch
from
d8decb5 to
eaf21ec
Compare
| @@ -324,6 +324,17 @@ | |||
| var isSvg = window.SVGElement && el instanceof window.SVGElement | |||
|
|
|||
| var elRect = el.getBoundingClientRect() | |||
| if (elRect.width == null) { | |||
| // width and height are missing in IE8, so compute them manually; see https://github.com/twbs/bootstrap/issues/14093 | |||
| elRect = { | |||
There was a problem hiding this comment.
IE8 doesn't let us add new properties to TextRectangle instances, so we have to make a whole new object (or use prototypes).
There was a problem hiding this comment.
i think something like elRect = $.extend({}, elRect, { width: … height …} would look a bit cleaner
There was a problem hiding this comment.
Sounds slower, but, alrighty.
cvrebert
force-pushed
the
ie8-getBoundingClientRect
branch
from
eaf21ec to
989dafb
Compare
|
@fat Okay, updated per your comment. LGTY? |
hnrch02
added a commit
that referenced
this pull request
Sep 11, 2014
Handle lack of .width and .height from getBoundingClientRect() in IE8
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #14093. Correction to #14090.
New relevant docs: https://developer.mozilla.org/en-US/docs/Web/API/Element.getBoundingClientRect#Browser_compatibility
This takes the same approach as ZeroClipboard.
CC: @fat