-
-
Notifications
You must be signed in to change notification settings - Fork 79k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tooltip occasionally won't hide when using a hide delay #14519
Conversation
that.$element.trigger('shown.bs.' + that.type) | ||
that.hoverState = null | ||
|
||
if (oldHoverState === 'out') that.leave(that) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Non strict comparison here, please.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah flip! Thought I got them things! 😎
Fixed in 54ee72470bad0eb72468fa06db39eb084c9a3f44
/to @fat for review |
(And we should squash the commits before merging) |
@cvrebert Squashed the commits into 1 😄 |
The unit test doesn't consistently fail on current master. |
@hnrch02 I can't get the tests to fail? Rebased with master to get latest changes and ran the tests so many times... |
That's kinda bad since we then can't detect any regression about this. |
Tell me about it. |
Yeah, try that. Will be necessary at some point anyways because of #14851. |
Think I've found the issue with the unit tests. The transitions are disabled on https://github.com/twbs/bootstrap/blob/master/js/tests/index.html#L55 And then in the tooltip.js file it fires the complete func immediately if I can reliably recreate the issue & see the fix in the visual tests. Obviously not great... Will see what I can do to get these tests to reliably fail. |
Yeah, testing without transitions is hard. I'll merge this anyway as we know it fixes the issue. If you come up with a solution though please do share. |
Fix for issue #14375
Error demo can be found on http://jsfiddle.net/d45cc0rs/
Fixed demo can be found on http://jsfiddle.net/7ga1mz6r/