Only enable pause: hover for non-touch browsers
#14626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/to @fat |
|
"Proper" touch detection is a bit more complicated, but we do already use the simple |
|
That's exactly my thinking, we do it like this for the dropdown plugin currently. Explained that in my #11967 comment. |
hnrch02
force-pushed
the
carousel-pause-hover-non-mobile
branch
from
4f5db43 to
c37c1a6
Compare
|
I added a basic unit test for this. |
|
awesome, thanks @hnrch02 |
fat
added a commit
that referenced
this pull request
Oct 3, 2014
Only enable `pause: hover` for non-touch browsers
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11967.