Hide and hidden events on tabs #14772
Conversation
|
Maybe add the new/next tab as the |
|
@hnrch02 How I didn't think of that I do not know.... Will add now. |
Related target contains the new tab to be shown
|
@hnrch02 Added them in & also fixed the indentation 😄 |
| var hideEvent = $.Event('hide.bs.tab', { | ||
| relatedTarget: $this[0] | ||
| }) | ||
| var showEvent = $.Event('show.bs.tab', { |
There was a problem hiding this comment.
Actually, you no longer need to indent these equals signs.
There was a problem hiding this comment.
@hnrch02 Do you want to me to undo them? Or leave as is? Any particular reason for this?
There was a problem hiding this comment.
Yeah, the equals signs should line up with one another but at maximally one space after the longest variable name of the block.
var foobar = 0
var foo = 1
var i = 2
var bar = 3I hope that explains it.
There was a problem hiding this comment.
@hnrch02 Make sense! I'll undo and keep them all at one space.
edit: They do line up at 1 space anyway..... 👀
| </tr> | ||
| <tr> | ||
| <td>hidden.bs.tab</td> | ||
| <td>This event fires after a new tab is shown.. Use <code>event.relatedTarget</code> to target the new tab.</td> |
|
I think the docs need to clarify the order that the 4 events are fired in. |
|
Updated the docs. Did you mean something like that? |
|
I had personally been thinking more like a short paragraph before the table that said "When switching to a different active tab, the events fire in the following order: ...". Just my opinion though. An issue with the current "fires ... and before ..." phrasing is that it could be misread as the event firing twice. |
|
The docs for collapse doesn't have that paragraph before it, so should that have it as well? |
|
@cvrebert Can we handle the docs issue in a separate PR? I'd like to merge this one. |
|
Okay |
|
I´ve got some strange issues, regarding to this issue. I´m using the Bootstrap 3.4.1 Tab-Sample-HTML. After clicking a nother tab, my tabs (a-tags) are getting a display: none. if i remove the line: $previous.trigger(hideEvent), it works. Can someone confirm this issue ? or am i the only one ? I´ve not changed anything.. it´s not working "out of the box". |
Based on #14768 I've added in two new events for tabs.
hideandhiddenFollows the exact same principal as the rest of these events!