Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try different HTML validator #15611

Merged
merged 2 commits into from
Feb 2, 2015
Merged

Try different HTML validator #15611

merged 2 commits into from
Feb 2, 2015

Conversation

mdo
Copy link
Member

@mdo mdo commented Jan 19, 2015

Switches from grunt-html-validation to grunt-html for faster validation via Gruntfile. Huge savings in a quick run, but unclear on the final results thus far.

/cc @cvrebert

@mdo mdo self-assigned this Jan 19, 2015
@cvrebert
Copy link
Collaborator

I'd like to wait for validator/grunt-html#38 to get fixed first.

@mdo
Copy link
Member Author

mdo commented Jan 22, 2015

Hey it works now!

@XhmikosR XhmikosR force-pushed the switch_html_validators branch 4 times, most recently from fded8ee to 3a13848 Compare January 27, 2015 16:14
@XhmikosR
Copy link
Member

Rebased and fixed ignores so that the task is passing.

@mdo
Copy link
Member Author

mdo commented Jan 30, 2015

Nice, thanks @XhmikosR. If y'all are down for this, I'm in. Let's :shipit: whenever we can.

@XhmikosR
Copy link
Member

From my quick tests, it works fine. So, if everyone agrees, feel free to push the button.

Personally, I have never used this validator before, but democracy :)

@cvrebert
Copy link
Collaborator

Submitted a PR to update grunt-html's copy of the validator: validator/grunt-html#39

@XhmikosR
Copy link
Member

Cool!

Reminder: we will probably need to clean up the ignores I added for the new validator version when it's out and before we merge this.

@cvrebert
Copy link
Collaborator

cvrebert commented Feb 1, 2015

The upstream PR got merged and there's now an updated release of grunt-html.

@hnrch02
Copy link
Collaborator

hnrch02 commented Feb 1, 2015

👍

@XhmikosR
Copy link
Member

XhmikosR commented Feb 1, 2015

Cool I'll check if we need to change the ignores and update the branch.
On Feb 1, 2015 11:21 PM, "Heinrich Fenkart" notifications@github.com
wrote:

[image: 👍]

—
Reply to this email directly or view it on GitHub
#15611 (comment).

@XhmikosR
Copy link
Member

XhmikosR commented Feb 2, 2015

Updated.

@XhmikosR XhmikosR added this to the v3.3.4 milestone Feb 2, 2015
@cvrebert
Copy link
Collaborator

cvrebert commented Feb 2, 2015

🚢

cvrebert added a commit that referenced this pull request Feb 2, 2015
@cvrebert
Merge pull request #15611 from twbs/switch_html_validators
ccd859f 
Use local HTML validator to improve performance
@cvrebert cvrebert merged commit ccd859f into master Feb 2, 2015
@cvrebert cvrebert deleted the switch_html_validators branch February 2, 2015 20:13
@cvrebert cvrebert mentioned this pull request Feb 2, 2015
Closed
@mdo
Copy link
Member Author

mdo commented Feb 2, 2015

:woohoo:!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mdo mdo

Labels
build meta
Projects
None yet
Milestone
v3.3.4
Development

Successfully merging this pull request may close these issues.
4 participants
@mdo @cvrebert @XhmikosR @hnrch02