Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Official Meteor integration #15716

Closed
wants to merge 3 commits into from
Closed

Official Meteor integration #15716

wants to merge 3 commits into from

Conversation

splendido
Copy link
Contributor

Hello guys,

As you might know, the Meteor community is widely using Bootstrap. We had many different wrapper packages all doing the same thing, so I'm submitting a PR that integrates Meteor packaging directly into your repository: at the end of this merge process, in case you'll find yourself comfortable with it, we'll get automated new meteor package releases at every new release of Bootstrap.

I'm aware of the previous attempt made by @dandv, but I've made this one as lean as possible so not to pick up too much space within your repository: basically it adds only a pacakge.js file among the ones already present for the other PMs. This should be not too much pretending.

All you have to do after accepting this PR would be:

  1. create an account at https://meteor.com/ (click SIGN IN, then Create account). After you've done that, please let me know the name of the account, and we'll add you as a maintainer of the twbs organization (which has been alredy reserved to make things simpler for you).
  2. head to autopublish.meteor.com sign in with your gitHub account, locate this repository and enable it for autopublish by toggling the checkbox you'll find on the right side of the repository item. You can get an idea about how Meteor Autopublish works by having a quick look at this page, but basically it creates a web hook to let us know when you push new tags. And when you'll release new versions, autopublish.meteor.com will automatically take delivery for publishing the new version also for Meteor!

Please note that you will not be able to toggle your repository until you'll have the package.js file on your master branch.

Please also note that we've already published the current version of the package on Atmosphere (Meteor's package directory) under the name twbs:bootstrap.
But if you think another name would be a better fit, just let us know!

Thanks in advance for your availability and collaboration and congratulation for the awesome project!
Luca & the Meteor integrations team


Package.onUse(function (api) {
api.versionsFrom('METEOR@1.0');
api.use('jquery');
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this line indented?


Package.onUse(function (api) {
api.versionsFrom('METEOR@1.0');
api.use('jquery', 'client');
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line asks Meteor to let this package see the jquery package (a core Meteor package actually) which exports the jQuery object you need in your dist/js/bootstrap.js.

...I've just updated it to better specify that the requirement is only for client code.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, but why is it indented more than the previous and subsequent lines?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, sorry, I've read 'intended'...

@cvrebert
Copy link
Collaborator

cvrebert commented Feb 1, 2015

As this version is basically akin to the existing Bower and Composer packagings (i.e. add one metadata file and a webhook), I'm +0.5 on this.

@mdo
Copy link
Member

mdo commented Feb 3, 2015

I'm for it as well.

@cvrebert Will our Grunt-based version updater address this file's version number as well, or do we need to do it manually?

@mdo mdo added this to the v3.3.4 milestone Feb 3, 2015
@cvrebert
Copy link
Collaborator

cvrebert commented Feb 3, 2015

It'll be automatic. The updater is overzealous, not underzealous.

@cvrebert
Copy link
Collaborator

@splendido @dandv Okay, we're going ahead with this. I created a Meteor account as cvrebert. Please add me to the twbs Meteor org per step 1 of your instructions.

@cvrebert cvrebert closed this in 90e7fc4 Feb 19, 2015
@cvrebert cvrebert mentioned this pull request Feb 19, 2015
@splendido
Copy link
Contributor Author

@cvrebert we'll have to wait for @dandv, he originally created the org and I have no access to it :(

@dandv
Copy link
Contributor

dandv commented Feb 21, 2015

Sorry guys, didn't see this. I've added both cvrebert and splendido to the MD org. Thanks for all your work!

@cvrebert
Copy link
Collaborator

Okay, I added the webhook. So, we're all good now, right?

@splendido
Copy link
Contributor Author

Yep!
Everything seems fine and ready for the autopublish at the next release :)

Thank you guys,
Keep up the awesome work!

@splendido
Copy link
Contributor Author

Eventually we had the proof that everything is set up correctly to publish new versions of the twbs:bootstrap meteor package within minutes from new releases!
See it on autopublish :-)

Thanks again everyone!
Cheers,
Luca

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants