-
-
Notifications
You must be signed in to change notification settings - Fork 78.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Official Meteor integration #15716
Official Meteor integration #15716
Conversation
|
||
Package.onUse(function (api) { | ||
api.versionsFrom('METEOR@1.0'); | ||
api.use('jquery'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this line indented?
|
||
Package.onUse(function (api) { | ||
api.versionsFrom('METEOR@1.0'); | ||
api.use('jquery', 'client'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line asks Meteor to let this package see the jquery
package (a core Meteor package actually) which exports the jQuery object you need in your dist/js/bootstrap.js
.
...I've just updated it to better specify that the requirement is only for client code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, but why is it indented more than the previous and subsequent lines?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh, sorry, I've read 'intended'...
As this version is basically akin to the existing Bower and Composer packagings (i.e. add one metadata file and a webhook), I'm +0.5 on this. |
I'm for it as well. @cvrebert Will our Grunt-based version updater address this file's version number as well, or do we need to do it manually? |
It'll be automatic. The updater is overzealous, not underzealous. |
@splendido @dandv Okay, we're going ahead with this. I created a Meteor account as |
Sorry guys, didn't see this. I've added both cvrebert and splendido to the MD org. Thanks for all your work! |
Okay, I added the webhook. So, we're all good now, right? |
Yep! Thank you guys, |
Eventually we had the proof that everything is set up correctly to publish new versions of the Thanks again everyone! |
Hello guys,
As you might know, the Meteor community is widely using Bootstrap. We had many different wrapper packages all doing the same thing, so I'm submitting a PR that integrates Meteor packaging directly into your repository: at the end of this merge process, in case you'll find yourself comfortable with it, we'll get automated new meteor package releases at every new release of Bootstrap.
I'm aware of the previous attempt made by @dandv, but I've made this one as lean as possible so not to pick up too much space within your repository: basically it adds only a
pacakge.js
file among the ones already present for the other PMs. This should be not too much pretending.All you have to do after accepting this PR would be:
twbs
organization (which has been alredy reserved to make things simpler for you).Please note that you will not be able to toggle your repository until you'll have the
package.js
file on your master branch.Please also note that we've already published the current version of the package on Atmosphere (Meteor's package directory) under the name
twbs:bootstrap
.But if you think another name would be a better fit, just let us know!
Thanks in advance for your availability and collaboration and congratulation for the awesome project!
Luca & the Meteor integrations team