Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Input group sizes: Properly position .form-control-feedback #15956

Merged
merged 1 commit into from
Mar 29, 2015

Conversation

hnrch02
Copy link
Collaborator

@hnrch02 hnrch02 commented Mar 1, 2015

Ref #12868 (comment)
Ref 7733f24

Before: http://jsbin.com/hubiju/1
After: http://jsbin.com/hubiju/2

The reason I didn't convert the selector into something like this

.input-lg,
.input-group-lg {
  + .form-control-feedback { ... }
}

is that it would be mixed into here.

/cc @mdo

@hnrch02 hnrch02 added the css label Mar 1, 2015
@hnrch02 hnrch02 added this to the v3.3.4 milestone Mar 1, 2015
@cvrebert cvrebert modified the milestones: v3.3.5, v3.3.4 Mar 15, 2015
@mdo
Copy link
Member

mdo commented Mar 27, 2015

Looks good to me I think.

mdo added a commit that referenced this pull request Mar 29, 2015
Input group sizes: Properly position `.form-control-feedback`
@mdo mdo merged commit e90d69c into master Mar 29, 2015
@mdo mdo deleted the input-group-sizes-glyphicon branch March 29, 2015 04:07
@cvrebert cvrebert mentioned this pull request Mar 29, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants