text-emphasis-variant mixin should change the anchor's "focused" state as well #16047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Note to team: If approved, this will require rebasing prior to merging so that the commit message can be changed to something more descriptive.) |
monoblaine
changed the title
| @@ -2,7 +2,7 @@ | |||
|
|
|||
| .text-emphasis-variant(@color) { | |||
| color: @color; | |||
| a&:hover { | |||
| a&:hover, a&:focus { | |||
There was a problem hiding this comment.
If we did this, this new selector would need to appear on the next line like so:
a&:hover,
a&:focus {
There was a problem hiding this comment.
I'm happy to fix that when rebasing this. Do you approve, in principle, of adding the selector?
There was a problem hiding this comment.
Yeah, seems fine to me. Let's do it.
Closed
|
👍 |
This was referenced Mar 26, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ".text-emphasis-variant" mixin does not change the anchor's color when the anchor is in the focused state, causing the link to have the default a:focus color (defined in https://github.com/twbs/bootstrap/blob/master/less/scaffolding.less#L53).