Fix #16072 - Clicking into input field within dropdown no longer closes the dropdown #16073
Conversation
|
Tests failed. Automated cross-browser testing via Sauce Labs and Travis CI shows that the JavaScript changes in this pull request are: BUSTED Commit: f2d61e01195ffc4fa32b32b3ab96cede6c1667f0 (Please note that this is a fully automated comment.) |
|
The failure on Travis seems to come from some timeout – do I need to do anything? |
|
@twbs-savage Retry |
|
Please test |
|
Also, excluding the |
| @@ -96,6 +96,8 @@ | |||
|
|
|||
| if (!$parent.hasClass('open')) return | |||
|
|
|||
| if (e && e.type === 'click' && /input|textarea/i.test(e.target.tagName) && $.contains($parent[0], e.target)) return | |||
There was a problem hiding this comment.
Should use == instead of ===, per Jacob's coding style.
|
Tests passed. Automated cross-browser testing via Sauce Labs and Travis CI shows that the JavaScript changes in this pull request are: CONFIRMED Commit: 164e712459577ef3378b51ffa842ce8ec376d7b1 (Please note that this is a fully automated comment.) |
|
Do you want me to do it on a separate branch and re-open a PR? |
|
If you know how to squash, just squash and force-push to the same branch. If not, one of us on the Core Team will take care of it. |
|
Done :) |
|
Tests passed. Automated cross-browser testing via Sauce Labs and Travis CI shows that the JavaScript changes in this pull request are: CONFIRMED Commit: 31a908f (Please note that this is a fully automated comment.) |
|
LGTM (Damn this style we use is hard to read :/)
|
cvrebert
changed the title
Fix #16072