Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset text/font properties more thoroughly for tooltips+popovers #16086

Merged
merged 3 commits into from
Apr 13, 2015

Conversation

cvrebert
Copy link
Collaborator

Fixes #15925.
Note: This changes the Tooltip line-height from 1.4 to @line-height-base (1.428571429)
Also enhances the explanatory comments a bit.

@cvrebert cvrebert added the css label Mar 16, 2015
@cvrebert cvrebert added this to the v3.3.5 milestone Mar 16, 2015
@mdo
Copy link
Member

mdo commented Mar 26, 2015

This seems like overkill honestly. In Primer, we've gotten away with around half this reset: https://github.com/primer/primer/blob/master/scss/_tooltips.scss. It doesn't cover the same amount of things as Bootstrap might encounter, but it's worked out well so far.

@cvrebert
Copy link
Collaborator Author

I grant you that font-kerning, text-indent, font-variant, and text-emphasis are more on the paranoid side. Would removing those alleviate your concerns?

Other than those, all this PR adds compared to Primer is:

line-break: auto;
word-break: normal;
word-spacing: normal;

which are more vanilla/common properties; I am thinking that hypothetical bugs caused by the lack of these 3 resets would end up being deemed legit bugs? So might as well just fix them now.

@mdo
Copy link
Member

mdo commented Mar 26, 2015

Sure, let's roll with those.

@cvrebert
Copy link
Collaborator Author

cvrebert commented Apr 8, 2015

@mdo Okay, revised. LGTY?

@mdo
Copy link
Member

mdo commented Apr 13, 2015

Yup, :shipit:.

cvrebert added a commit that referenced this pull request Apr 13, 2015
Reset text/font properties more thoroughly for tooltips+popovers
@cvrebert cvrebert merged commit 150d454 into master Apr 13, 2015
@cvrebert cvrebert deleted the fix-15925 branch April 13, 2015 00:08
@cvrebert cvrebert mentioned this pull request Apr 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tooltips and popovers still inherit font-style and others
2 participants