-
-
Notifications
You must be signed in to change notification settings - Fork 78.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
affix plugin does not work within a pulled/pushed column #16282
Conversation
…ns in Safari, and the width isn't right anywhere twbs/bootstrap#12126 / twbs/bootstrap#16282 Reverse the columns so there is no pushing/pulling. Set the width in Javascript, or else the nav extends into the other column.
@@ -8,6 +8,7 @@ <h2 id="affix-examples">Example</h2> | |||
|
|||
<h2 id="affix-usage">Usage</h2> | |||
<p>Use the affix plugin via data attributes or manually with your own JavaScript. <strong class="text-danger">In both situations, you must provide CSS for the positioning and width of your affixed content.</strong></p> | |||
<p>Note: Do not use the affix plugin on an element contained in a relatively positioned element, such as a pulled or pushed column, due to a <a href="https://github.com/twbs/bootstrap/issues/12126">bug in rendering in Safari</a>.</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tweak phrasing: "Safari rendering bug"
This documents the limitation discussed in #12126: > When using column reordering and using the affix-plugin on an element positioned with push, the affix plugin doesn't work correctly - the element affected by the affix plugin is positioned to the left even when the element is in a column positioned on the right. Seems to affect Safari (tested in version 8) only. That issue has (unfortunately) been closed, so this at least documents the behavior.
@cvrebert : Got it. I force-pushed to my branch to update the PR in place. |
@mdo LGTY? |
Yeah, sounds good. Totally didn't remember it was only Safari. |
affix plugin does not work within a pulled/pushed column
Thanks to both of you! |
I just noticed that was happening on something I built. In addition to the more elaborate solutions posed in the main issue thread (that's now locked), just thought I'd share the very simple workaround I have to turn off affix in Safari. Much better to lose the affix functionality than to have unreadable, overlapping content.
|
…ns in Safari, and the width isn't right anywhere twbs/bootstrap#12126 / twbs/bootstrap#16282 Reverse the columns so there is no pushing/pulling. Set the width in Javascript, or else the nav extends into the other column.
This documents the limitation discussed in #12126:
Seems to affect Safari (tested in version 8) only.
That issue has (unfortunately) been closed, so this at least documents the behavior.