Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More bower.json fixes #16379

Merged
merged 2 commits into from
Apr 27, 2015
Merged

More bower.json fixes #16379

merged 2 commits into from
Apr 27, 2015

Conversation

cvrebert
Copy link
Collaborator

@cvrebert cvrebert added the meta label Apr 27, 2015
@cvrebert cvrebert added this to the v3.3.5 milestone Apr 27, 2015
cvrebert added a commit that referenced this pull request Apr 27, 2015
@cvrebert cvrebert merged commit cc8567d into master Apr 27, 2015
@cvrebert cvrebert deleted the bower-json branch April 27, 2015 17:52
@cvrebert cvrebert mentioned this pull request Apr 27, 2015
@@ -1,7 +1,6 @@
{
"name": "bootstrap",
"description": "The most popular front-end framework for developing responsive, mobile first projects on the web.",
"version": "3.3.4",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI: I had in my bower file v3.3.* and the removal of version broke my build using grunt wiredep, for anyone else that might have come across the same issue. It's ok now, I don't need the version in the bower file. I just locked down the specific version and it works. Out of curiosity, may I ask why remove the version in the bower file?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@byronmansfield As noted in both the commit message and pull request description, see bower/spec@a325da3

@twbs twbs locked and limited conversation to collaborators Jun 22, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants