dropdowns.less: Add space before IE8 workaround. #16384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
X-Ref: #16258 |
|
I've confirmed via Sauce that adding the space doesn't degrade the effectiveness of the IE8 fix. |
|
OK, so it's good to go then? |
|
BTW, don't forget to update the node_modules in bot and shrinkwrap for the new clean-css version. |
|
The bot installs using the shrinkwrap file on every build, so we just need to reshrinkwrap. |
|
All right, done. |
|
Now, this PR is basically a consistency change since in all other cases we use |
| @@ -11,7 +11,7 @@ | |||
| margin-left: 2px; | |||
| vertical-align: middle; | |||
| border-top: @caret-width-base dashed; | |||
| border-top: @caret-width-base ~"solid\9"; // IE8 | |||
| border-top: @caret-width-base ~"solid \9"; // IE8 | |||
There was a problem hiding this comment.
Perhaps we should use
border-top: @caret-width-base solid ~"\9"?
There was a problem hiding this comment.
It results to the same CSS, not sure which one is preferable.
XhmikosR
force-pushed
the
cleancss-workaround
branch
from
ef50d8f
to
1a44524
Compare
This in turn works around an issue with clean-css (fixed in 3.2.6). So this basically is just a consistency change.
XhmikosR
force-pushed
the
cleancss-workaround
branch
from
1a44524
to
5ca44f9
Compare
|
|
XhmikosR
added a commit
that referenced
this pull request
Apr 29, 2015
dropdowns.less: Add space before IE8 workaround.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This in turn works around an issue with clean-css.
clean-css/clean-css#556
/CC @cvrebert @mdo